You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One option is to, instead, take a Felt as argument. But then, we also need to rework the rpo module documentation that also mentions 64-bit - and it is important we keep consistency between these, as RPO is the backend of SimpleSmt
Currently, the key bits are documented as
63-bit
crypto/src/merkle/simple_smt/mod.rs
Lines 9 to 13 in 398af59
However, we take
u64
as arguments. This difference might create a confusion downstream.crypto/src/merkle/simple_smt/mod.rs
Lines 153 to 154 in 398af59
One option is to, instead, take a
Felt
as argument. But then, we also need to rework the rpo module documentation that also mentions64-bit
- and it is important we keep consistency between these, as RPO is the backend ofSimpleSmt
crypto/src/hash/rpo/mod.rs
Lines 60 to 65 in 398af59
Originally posted by @grjte in #64 (comment)
The text was updated successfully, but these errors were encountered: