Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify AccountDetails in ProvenTransaction #524

Closed
bobbinth opened this issue Mar 12, 2024 · 3 comments
Closed

Simplify AccountDetails in ProvenTransaction #524

bobbinth opened this issue Mar 12, 2024 · 3 comments
Assignees
Labels
refactoring Code clean-ups, improvements, and refactoring
Milestone

Comments

@bobbinth
Copy link
Contributor

As noted by @hackaugusto in #485 (comment), we may be able to simplify AccountDetails in the ProvenTransaction struct to carry just account delta (even in the case of new accounts).

@bobbinth bobbinth added the refactoring Code clean-ups, improvements, and refactoring label Mar 12, 2024
@polydez polydez self-assigned this Mar 19, 2024
@polydez polydez moved this to In Progress in Builder's testnet Mar 19, 2024
@polydez
Copy link
Contributor

polydez commented Mar 20, 2024

@bobbinth @hackaugusto
One thing we've missed: Account also contains account's code, but we don't have such analogue in AccountDelta. In our previous design, we was able to deploy code once and then update other data, so if we add this field to AccountDelta, it will be useless for updates in existing accounts. Do we have another approach of account's code deployment?

@bobbinth
Copy link
Contributor Author

The proper way to handle it is to add account code updates to AccountDelta as well. But this is quite a bit of work and I'm not sure we should dedicate time to this now.

So, I'm thinking we just put #530 on hold for now and come back to it later.

@polydez
Copy link
Contributor

polydez commented Apr 22, 2024

We decided to not keep only delta, because this makes code even worse due to additional cases to check: #530 (comment)

@polydez polydez closed this as completed Apr 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in User's testnet Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code clean-ups, improvements, and refactoring
Projects
Status: Done
Development

No branches or pull requests

2 participants