Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize FeltRng as the RNG component #244

Closed
igamigo opened this issue Apr 1, 2024 · 1 comment
Closed

Utilize FeltRng as the RNG component #244

igamigo opened this issue Apr 1, 2024 · 1 comment
Milestone
v03

Comments

@igamigo
Copy link
Collaborator

igamigo commented Apr 1, 2024 •
edited
Loading

What should be done?

FeltRng now implements RngCore and so we can use fill_bytes() from its API (done in 0xPolygonMiden/crypto#299 and v0.9.0 of miden-crypto has been released). After a new version of Miden VM is released and these changes are available to downstream crates we need to remove ClientRng and enforce only FeltRng for the RNG component of the Client.

How should it be done?

Remove ClientRng and make sure only FeltRng is utilized. Also we should confirm that this is the only source of randomness.

When is this task done?

After the RNG component of Client is FeltRng

Additional context

#236 (comment)
@igamigo igamigo mentioned this issue Apr 4, 2024
Merged
@Dominik1999 Dominik1999 added this to the v03 milestone Apr 14, 2024
@mFragaBA
Copy link
Contributor

Closing as #245 already got merged (the PR was missing the "Closes #ISSUE_NUMBER")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
User's testnet
Status: Done
Milestone
v03
Development

No branches or pull requests
3 participants
@igamigo @mFragaBA @Dominik1999