Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'check' to Makefile and CI checks for miden-client (regular and WASM) #450

Closed
dagarcia7 opened this issue Jul 29, 2024 · 1 comment · Fixed by #456
Closed

Add 'check' to Makefile and CI checks for miden-client (regular and WASM) #450

dagarcia7 opened this issue Jul 29, 2024 · 1 comment · Fixed by #456
Assignees
Milestone

Comments

@dagarcia7
Copy link
Collaborator

What should be done?

Per @bobbinth's idea here #437 (comment), we should add a check to the Makefile in the miden-client repo which would run both regular and WASM checks as part of CI.

How should it be done?

  • Add check for rust client and binary
  • Add check for WASM
  • Incorporate these checks into a CI process

When is this task done?

The task is done when the check commands have been added to the Makefile and incorporated into the CI pipeline.

Additional context

No response

@bobbinth bobbinth added this to the v0.5 milestone Jul 29, 2024
@SantiagoPittella SantiagoPittella self-assigned this Jul 31, 2024
@SantiagoPittella SantiagoPittella linked a pull request Jul 31, 2024 that will close this issue
2 tasks
@SantiagoPittella
Copy link
Collaborator

As discussed in #456 (this comment), I added a target in the Makefile to run check but it is not necessary in the CI.

Let me know if you think that is in fact necessary. 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants