Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure that both the account and public key get inserted successfully in the CLI #731

Open
tomyrd opened this issue Feb 12, 2025 · 0 comments

Comments

@tomyrd
Copy link
Collaborator

tomyrd commented Feb 12, 2025

In #718 we separated the secret key storage from the Client. The CLI now has the responsibility of adding new keys to the keystore, but there could be a case where the key is inserted but the new account can be added to the client.

This is fine for now but maybe we could add a TODO here to address potential cases where adding the secret key succeeds, but adding the account fails.

Alternatively, maybe in the future we want to have some sort of "keystore" command that adds/removes keys separately from accounts.

Originally posted by @igamigo in #718 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant