Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & improve ClientBuilder #759

Open
partylikeits1983 opened this issue Feb 24, 2025 · 0 comments
Open

Refactor & improve ClientBuilder #759

partylikeits1983 opened this issue Feb 24, 2025 · 0 comments
Milestone

Comments

@partylikeits1983
Copy link

After opening #741, there are a few optimizations that can be made. The goal of #741 is to provide the option to make initialization of the miden-client as simple as possible. Here are the three main issues (as discussed in the comments of #741) that need to be addressed to optimize the current implementation of the ClientBuilder.

  1. Make handling of KeyStore more generic (so that we could use non-FilesystemKeyStores as well).
  2. Make handling of Rng more generic (so that we could use non-RpoRandomCoin as well).
  3. Modifying rpc/tonic_client/mod.rs to avoid having the #[cfg(feature="std")] guard for the ClientBuilder mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants