Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for on-chain notes #141

Closed
bobbinth opened this issue Jan 11, 2024 · 5 comments
Closed

Implement support for on-chain notes #141

bobbinth opened this issue Jan 11, 2024 · 5 comments
Assignees
Labels
block-producer Related to the block producer component rpc Related to the RPC component store Related to the store component
Milestone

Comments

@bobbinth
Copy link
Contributor

Currently, the node can handle only off-chain notes. To support on-chain notes we'd need to do the following:

  1. Add necessary tables to the store database to store on-chain note info.
  2. Update block producer to make sure it extracts on-chain note data from proven transactions and send this data to the store via apply_block.
  3. Update the store to record the on-chain note data in the DB.
  4. Update the store and the RPC to provide an endpoint for users to retrieve on-chain note details
    a. Maybe also update sync_state endpoint to return on-chain note details for such notes (though, this requires a bit more thinking).

This work requires 0xPolygonMiden/miden-base#403 to be completed.

@bobbinth bobbinth added store Related to the store component rpc Related to the RPC component block-producer Related to the block producer component labels Jan 11, 2024
@bobbinth bobbinth added this to the v0.2 milestone Jan 11, 2024
@hackaugusto
Copy link
Contributor

For some context:

related issues in miden-base: 0xPolygonMiden/miden-base#403 0xPolygonMiden/miden-base#402
related PRs so far: 0xPolygonMiden/miden-base#481 0xPolygonMiden/miden-base#485

@Dominik1999
Copy link
Contributor

Dominik1999 commented Mar 22, 2024

We break it down into smaller issues @hackaugusto @Dominik1999 @bobbinth

  • issue to create an endpoint
  • issue for DB
  • ...

@Dominik1999
Copy link
Contributor

@bobbinth see comment above

@Dominik1999 Dominik1999 moved this from Todo to Blocked in Builder's testnet Mar 25, 2024
@bobbinth
Copy link
Contributor Author

I broke out points 1 and 4 into separate issues: #286 and #288. So, this issue is now only for points 2 and 3 of the original description. I think the order of implementation could be:

  1. Update storage to support on-chain notes #288
  2. Implement GetNotesById endpoint #286
  3. And then this issue.

@Dominik1999
Copy link
Contributor

Should be closed by #310

@github-project-automation github-project-automation bot moved this from In Review to Done in Builder's testnet Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-producer Related to the block producer component rpc Related to the RPC component store Related to the store component
Projects
Status: Done
Development

No branches or pull requests

4 participants