Skip to content

Commit bd0916d

Browse files
add arc on builder
1 parent 73dc93a commit bd0916d

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

engineio/src/asynchronous/client/builder.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ impl ClientBuilder {
5858
}
5959

6060
/// Specify Packet Serializer
61-
pub fn packet_serializer(mut self, packet_serializer: PacketSerializer) -> Self {
62-
self.serializer = Arc::new(packet_serializer);
61+
pub fn packet_serializer(mut self, packet_serializer: Arc<PacketSerializer>) -> Self {
62+
self.serializer = packet_serializer;
6363

6464
self
6565
}

socketio/src/asynchronous/client/builder.rs

+6-5
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use rust_engineio::{
55
asynchronous::ClientBuilder as EngineIoClientBuilder,
66
header::{HeaderMap, HeaderValue},
77
};
8-
use std::collections::HashMap;
8+
use std::{collections::HashMap, sync::Arc};
99
use url::Url;
1010

1111
use crate::{error::Result, Event, PacketSerializer, Payload, TransportType};
@@ -31,7 +31,7 @@ pub struct ClientBuilder {
3131
tls_config: Option<TlsConnector>,
3232
opening_headers: Option<HeaderMap>,
3333
transport_type: TransportType,
34-
packet_serializer: PacketSerializer,
34+
packet_serializer: Arc<PacketSerializer>,
3535
pub(crate) auth: Option<serde_json::Value>,
3636
pub(crate) reconnect: bool,
3737
pub(crate) reconnect_on_disconnect: bool,
@@ -91,7 +91,7 @@ impl ClientBuilder {
9191
tls_config: None,
9292
opening_headers: None,
9393
transport_type: TransportType::default(),
94-
packet_serializer: PacketSerializer::default(),
94+
packet_serializer: PacketSerializer::default_arc(),
9595
auth: None,
9696
reconnect: true,
9797
reconnect_on_disconnect: false,
@@ -415,7 +415,7 @@ impl ClientBuilder {
415415
/// }
416416
/// ```
417417
pub fn packet_serializer(mut self, packet_serializer: PacketSerializer) -> Self {
418-
self.packet_serializer = packet_serializer;
418+
self.packet_serializer = Arc::new(packet_serializer);
419419

420420
self
421421
}
@@ -462,7 +462,8 @@ impl ClientBuilder {
462462
url.set_path("/socket.io/");
463463
}
464464

465-
let mut builder = EngineIoClientBuilder::new(url);
465+
let mut builder =
466+
EngineIoClientBuilder::new(url).packet_serializer(self.packet_serializer.clone());
466467

467468
if let Some(tls_config) = &self.tls_config {
468469
builder = builder.tls_config(tls_config.to_owned());

socketio/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ pub use error::Error;
193193

194194
pub use {event::Event, payload::Payload};
195195

196-
pub use rust_engineio::Error as EngineIOError;
197196
pub use client::{ClientBuilder, EngineIOPacket, PacketSerializer, RawClient, TransportType};
197+
pub use rust_engineio::Error as EngineIOError;
198198

199199
// TODO: 0.4.0 remove
200200
#[deprecated(since = "0.3.0-alpha-2", note = "Socket renamed to Client")]

0 commit comments

Comments
 (0)