Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let handle_event provide Vec<Value> to self.callback #394

Closed
wants to merge 2 commits into from

Conversation

kitgxrl
Copy link

@kitgxrl kitgxrl commented Feb 1, 2024

This allows the client to receive multiple messages in one event if a server sends that way, e.g. 42["chat", user_information, chat_message] is one of many events in my server I'm working with at the moment. Some of this can be chalked up to poor socket design but it's still something socket.io allows.

Unsure if this is the best way to approach this problem! It appears to work in my project fine with little to no issues.

@shenjackyuanjie
Copy link
Contributor

@kitgxrl
have a look at my PR, #392
it's the same thing

@kitgxrl
Copy link
Author

kitgxrl commented Feb 4, 2024

@kitgxrl have a look at my PR, #392 it's the same thing

Sorry! Only now noticed that issue was the same thing, thought it was regarding something else! That's my mistake. Closing now.

@kitgxrl kitgxrl closed this Feb 4, 2024
@shenjackyuanjie
Copy link
Contributor

it's fine, I have notice that you modify the async client and the raw_client would you like to test my PR since I only modify raw_client, async part may not work

@kitgxrl
Copy link
Author

kitgxrl commented Feb 10, 2024

Hey! Sorry for late reply. Been busy with personal stuff. I personally don't use async client since the lack of reconnection is kinda a deal breaker since I need to be able to reliably reconnect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants