From 0e4c164c886dc6a83a1edafe814663eaa82f6e60 Mon Sep 17 00:00:00 2001
From: Yongting You <2010youy01@gmail.com>
Date: Sat, 22 Feb 2025 18:59:39 +0800
Subject: [PATCH] fix

---
 datafusion/core/tests/memory_limit/mod.rs  | 5 ++---
 datafusion/physical-plan/src/sorts/sort.rs | 4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/datafusion/core/tests/memory_limit/mod.rs b/datafusion/core/tests/memory_limit/mod.rs
index eb2a3c37f45d..2deb8fde2da6 100644
--- a/datafusion/core/tests/memory_limit/mod.rs
+++ b/datafusion/core/tests/memory_limit/mod.rs
@@ -26,7 +26,6 @@ mod memory_limit_validation;
 use arrow::array::{ArrayRef, DictionaryArray, Int32Array, RecordBatch, StringViewArray};
 use arrow::compute::SortOptions;
 use arrow::datatypes::{Int32Type, SchemaRef};
-use arrow::util::pretty;
 use arrow_schema::{DataType, Field, Schema};
 use datafusion::assert_batches_eq;
 use datafusion::datasource::memory::MemorySourceConfig;
@@ -46,7 +45,7 @@ use datafusion_execution::memory_pool::{
     FairSpillPool, GreedyMemoryPool, MemoryPool, TrackConsumersPool,
 };
 use datafusion_execution::TaskContext;
-use datafusion_expr::{col, Expr, TableType};
+use datafusion_expr::{Expr, TableType};
 use datafusion_physical_expr::{LexOrdering, PhysicalSortExpr};
 use datafusion_physical_optimizer::join_selection::JoinSelection;
 use datafusion_physical_optimizer::PhysicalOptimizerRule;
@@ -466,7 +465,7 @@ async fn test_stringview_external_sort() {
         .await
         .unwrap();
 
-    let results = df.collect().await.expect("Query execution failed");
+    let _ = df.collect().await.expect("Query execution failed");
 }
 
 /// Run the query with the specified memory limit,
diff --git a/datafusion/physical-plan/src/sorts/sort.rs b/datafusion/physical-plan/src/sorts/sort.rs
index 2b00fc600d6f..23e4ef223ac4 100644
--- a/datafusion/physical-plan/src/sorts/sort.rs
+++ b/datafusion/physical-plan/src/sorts/sort.rs
@@ -461,7 +461,7 @@ impl ExternalSorter {
                     new_columns.push(Arc::new(new_array));
                     arr_mutated = true;
                 } else {
-                    new_columns.push(array.clone());
+                    new_columns.push(Arc::clone(array));
                 }
             }
 
@@ -1478,7 +1478,7 @@ mod tests {
         // Processing 840 KB of data using 400 KB of memory requires at least 2 spills
         // It will spill roughly 18000 rows and 800 KBytes.
         // We leave a little wiggle room for the actual numbers.
-        assert!((2..=10).contains(&spill_count));
+        assert!((12..=18).contains(&spill_count));
         assert!((15000..=20000).contains(&spilled_rows));
         assert!((700000..=900000).contains(&spilled_bytes));