From 0f2c167c3070be9f35a409bd1c6718659d7638e6 Mon Sep 17 00:00:00 2001 From: Ariel Gentile Date: Mon, 2 Dec 2024 21:35:25 -0300 Subject: [PATCH 1/2] fix(calls): description optional and null types --- packages/calls/src/DidCommCallsService.ts | 2 +- packages/calls/src/DidcommCallsApi.ts | 2 +- packages/calls/src/messages/CallOfferMessage.ts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/calls/src/DidCommCallsService.ts b/packages/calls/src/DidCommCallsService.ts index 75f75a0..3e26ead 100644 --- a/packages/calls/src/DidCommCallsService.ts +++ b/packages/calls/src/DidCommCallsService.ts @@ -11,7 +11,7 @@ export class DidCommCallsService { callType: DidCommCallType offerExpirationTime?: Date offerStartTime?: Date - description: string + description?: string parameters: Record }) { const { callType, offerExpirationTime, offerStartTime, description, parameters } = options diff --git a/packages/calls/src/DidcommCallsApi.ts b/packages/calls/src/DidcommCallsApi.ts index 9696f5e..c19e4d0 100644 --- a/packages/calls/src/DidcommCallsApi.ts +++ b/packages/calls/src/DidcommCallsApi.ts @@ -27,7 +27,7 @@ export class DidCommCallsApi { callType: DidCommCallType offerExpirationTime?: Date offerStartTime?: Date - description: string + description?: string parameters: Record }) { const { connectionId, callType, offerExpirationTime, offerStartTime, description, parameters } = options diff --git a/packages/calls/src/messages/CallOfferMessage.ts b/packages/calls/src/messages/CallOfferMessage.ts index 887011f..e71f2a3 100644 --- a/packages/calls/src/messages/CallOfferMessage.ts +++ b/packages/calls/src/messages/CallOfferMessage.ts @@ -36,13 +36,13 @@ export class CallOfferMessage extends AgentMessage { @IsOptional() @Expose({ name: 'offer_expiration_time' }) @DateTransformer() - public offerExpirationTime?: Date | null + public offerExpirationTime?: Date @IsDate() @IsOptional() @DateTransformer() @Expose({ name: 'offer_start_time' }) - public offerStartTime?: Date | null + public offerStartTime?: Date public description?: string From 181044c97eeca9cc8b8441e401267d9b0de65d6b Mon Sep 17 00:00:00 2001 From: Ariel Gentile Date: Mon, 2 Dec 2024 22:03:46 -0300 Subject: [PATCH 2/2] Update packages/calls/src/messages/CallOfferMessage.ts Co-authored-by: andresfv95 --- packages/calls/src/messages/CallOfferMessage.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/calls/src/messages/CallOfferMessage.ts b/packages/calls/src/messages/CallOfferMessage.ts index e71f2a3..f312519 100644 --- a/packages/calls/src/messages/CallOfferMessage.ts +++ b/packages/calls/src/messages/CallOfferMessage.ts @@ -44,6 +44,7 @@ export class CallOfferMessage extends AgentMessage { @Expose({ name: 'offer_start_time' }) public offerStartTime?: Date + @IsOptional() public description?: string public parameters!: Record