Ensure log4j-slf4j2-impl bridge exists to forward slf4J logs to log4j…

…. Move that and log4j-core to dspace-api so it is inherited everywhere else.
4Science · Nov 21, 2024 · 1b06816 · 1b06816
1 parent 40fbd80
commit 1b06816
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 16 deletions.
diff --git a/dspace-api/pom.xml b/dspace-api/pom.xml
@@ -341,6 +341,14 @@
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-api</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>
+            <artifactId>log4j-core</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>
+            <artifactId>log4j-slf4j2-impl</artifactId>
+        </dependency>
         <dependency>
             <groupId>org.hibernate.orm</groupId>
             <artifactId>hibernate-core</artifactId>

diff --git a/dspace-oai/pom.xml b/dspace-oai/pom.xml
@@ -119,10 +119,6 @@
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-api</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.apache.logging.log4j</groupId>
-            <artifactId>log4j-core</artifactId>
-        </dependency>
 
         <!-- Testing -->
         <dependency>

diff --git a/dspace-rdf/pom.xml b/dspace-rdf/pom.xml
@@ -85,10 +85,6 @@
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-api</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.apache.logging.log4j</groupId>
-            <artifactId>log4j-core</artifactId>
-        </dependency>
 
         <dependency>
             <groupId>org.apache.commons</groupId>

diff --git a/dspace-sword/pom.xml b/dspace-sword/pom.xml
@@ -73,10 +73,6 @@
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-api</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.apache.logging.log4j</groupId>
-            <artifactId>log4j-core</artifactId>
-        </dependency>
 
         <dependency>
             <groupId>xom</groupId>

diff --git a/dspace-swordv2/pom.xml b/dspace-swordv2/pom.xml
@@ -91,10 +91,6 @@
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-api</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.apache.logging.log4j</groupId>
-            <artifactId>log4j-core</artifactId>
-        </dependency>
     </dependencies>
 
 </project>
diff --git a/pom.xml b/pom.xml
@@ -1594,6 +1594,12 @@
                 <artifactId>log4j-core</artifactId>
                 <version>${log4j.version}</version>
             </dependency>
+            <!-- This bridge ensures any logging to slf4j is sent to log4j -->
+            <dependency>
+                <groupId>org.apache.logging.log4j</groupId>
+                <artifactId>log4j-slf4j2-impl</artifactId>
+                <version>${log4j.version}</version>
+            </dependency>
 
             <dependency>
                 <groupId>org.apache.pdfbox</groupId>