omit placeholders for external identifiers

4Science · Jan 27, 2025 · 8eebaf4 · 8eebaf4
1 parent c0d2912
commit 8eebaf4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/dspace-api/src/main/java/org/dspace/orcid/model/factory/impl/OrcidProductWorkFactory.java b/dspace-api/src/main/java/org/dspace/orcid/model/factory/impl/OrcidProductWorkFactory.java
@@ -202,7 +202,10 @@ private List<ExternalID> getWorkSelfExternalIds(Context context, Item item) {
     private ExternalID getSelfExternalId(MetadataValue metadataValue) {
         Map<String, String> externalIdentifierFields = fieldMapping.getExternalIdentifierFields();
         String metadataField = metadataValue.getMetadataField().toString('.');
-        return getExternalId(externalIdentifierFields.get(metadataField), metadataValue.getValue(), SELF);
+        if (isNotPlaceholder(metadataValue)) {
+            return getExternalId(externalIdentifierFields.get(metadataField), metadataValue.getValue(), SELF);
+        }
+        return null;
     }
 
     private List<ExternalID> getWorkFundedByExternalIds(Context context, Item item) {

diff --git a/dspace-api/src/main/java/org/dspace/orcid/model/factory/impl/OrcidWorkFactory.java b/dspace-api/src/main/java/org/dspace/orcid/model/factory/impl/OrcidWorkFactory.java
@@ -203,7 +203,10 @@ private List<ExternalID> getWorkSelfExternalIds(Context context, Item item) {
     private ExternalID getSelfExternalId(MetadataValue metadataValue) {
         Map<String, String> externalIdentifierFields = fieldMapping.getExternalIdentifierFields();
         String metadataField = metadataValue.getMetadataField().toString('.');
-        return getExternalId(externalIdentifierFields.get(metadataField), metadataValue.getValue(), SELF);
+        if (isNotPlaceholder(metadataValue)) {
+            return getExternalId(externalIdentifierFields.get(metadataField), metadataValue.getValue(), SELF);
+        }
+        return null;
     }
 
     private List<ExternalID> getWorkFundedByExternalIds(Context context, Item item) {