You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we're storing important information in containers.json we should add a CI linting check when it is updated. It is quite easy to make a syntax error, especially with quoted strings.
There are some GitHub marketplace actions, but nothing maintained/well-used/appropriate so probably sufficient to just use jq in this case, so see jqlang/jq#1637 (comment)
I should have picked this up when reviewing #42, sorry, but we should be doing at least a linting check on https://github.com/ACCESS-NRI/build-ci/blob/main/containers/compilers.json
If we're storing important information in containers.json we should add a CI linting check when it is updated. It is quite easy to make a syntax error, especially with quoted strings.
There are some GitHub marketplace actions, but nothing maintained/well-used/appropriate so probably sufficient to just use jq in this case, so see jqlang/jq#1637 (comment)
or jqlang/jq#1539 and check "array" is returned:
If we really wanted to check
compilers.json
file validity we would create a JSON schema and validate against it.There is a marketplace action to do that, but it doesn't seem to be actively maintained
https://github.com/marketplace/actions/validate-json
There are lots of implementations, for CLI though it is either npm based or go based which might just introduce a whole lot of dependency hell.
A non-CLI python option is https://horejsek.github.io/python-fastjsonschema/
The text was updated successfully, but these errors were encountered: