Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated -fp-model compiler flag within oasis3-mct #199

Open
manodeep opened this issue Feb 19, 2025 · 4 comments
Open

Repeated -fp-model compiler flag within oasis3-mct #199

manodeep opened this issue Feb 19, 2025 · 4 comments

Comments

@manodeep
Copy link
Contributor

This line contains a repeated flag for -fp-model - there should be only one. With the assumption that this flag (NCI_REPRO_FLAGS) is only used within a reproducibility context, I would say that the value should be set to strict i.e., neither of the precise and source values on the line.

@harshula
Copy link
Collaborator

Hi @manodeep , You may want to have that discussion in ACCESS-NRI/ACCESS-OM2#12

@manodeep
Copy link
Contributor Author

Hmm - that is a giant issue with multiple components and that makes tracking individual items trickier. I prefer having smaller issues that are more easily tracked and resolved. In this case, a repeated compiler flag is a different category than what the compiler flags should be.

As to which value of the -fp-model we should use for REPRO - sure thing. I will add that to the other issue you have mentioned.

@harshula
Copy link
Collaborator

Hi @manodeep , Isn't your question relevant to all the components covered in ACCESS-NRI/ACCESS-OM2#12 ?

oasis3-mct: ACCESS-NRI/ACCESS-OM2#12 (comment)
libaccessom2: ACCESS-NRI/ACCESS-OM2#12 (comment)
cice5: ACCESS-NRI/ACCESS-OM2#12 (comment)
mom5: ACCESS-NRI/ACCESS-OM2#12 (comment)

@manodeep
Copy link
Contributor Author

@harshula Ahhh I think I know what you mean - the repeated -fp-model flag issue is present in all the components and hence needs to be referenced in the parent issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants