From 48fbf31826dac54812ff436acf01dd5eb7c92552 Mon Sep 17 00:00:00 2001 From: Menkene Koufan Date: Fri, 4 Oct 2024 13:03:32 +0100 Subject: [PATCH] chore: proper implementation for auditor access --- .../ledgers/baam/db/domain/AuditorAccess.java | 33 +++---------------- .../repository/AuditorAccessRepository.java | 2 +- 2 files changed, 5 insertions(+), 30 deletions(-) diff --git a/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/domain/AuditorAccess.java b/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/domain/AuditorAccess.java index 96777a4bd..c4b547319 100644 --- a/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/domain/AuditorAccess.java +++ b/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/domain/AuditorAccess.java @@ -1,42 +1,17 @@ package de.adorsys.ledgers.baam.db.domain; -import jakarta.persistence.*; -import java.util.logging.Logger; +import jakarta.persistence.Entity; +import jakarta.persistence.Table; @Entity @Table(name = "auditor_access") public class AuditorAccess extends BankAccountAccess { - private static final Logger logger = Logger.getLogger(AuditorAccess.class.getName()); - // Constructor sets default values public AuditorAccess() { + super(); this.setStatus(AccessStatus.ACTIVE); // By default, AuditorAccess is active - this.setWeight(1.0); // Weight is always 1 for AuditorAccess - logger.info("AuditorAccess created with default active status and weight of 1"); + this.setWeight(1.0); // Weight is always 1 for Auditor Access } - public boolean allowsAction(String action) { - // Only allow read actions such as viewing transactions and balances - return switch (action) { - case "VIEW_ACCOUNT_BALANCES", "VIEW_TRANSACTION_HISTORY", "VIEW_ACCESS_LOGS" -> true; - default -> false; // No modifications are allowed - }; - } - - // Overriding status management to ensure that AuditorAccess can be restricted or suspended - public void suspendAccess() { - this.setStatus(AccessStatus.SUSPENDED); - logger.info("AuditorAccess has been suspended."); - } - - public void activateAccess() { - this.setStatus(AccessStatus.ACTIVE); - logger.info("AuditorAccess has been reactivated."); - } - - public void restrictAccess() { - this.setStatus(AccessStatus.RESTRICTED); - logger.info("AuditorAccess has been restricted."); - } } diff --git a/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/repository/AuditorAccessRepository.java b/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/repository/AuditorAccessRepository.java index d7b6b95e1..f7eab8206 100644 --- a/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/repository/AuditorAccessRepository.java +++ b/ledgers-bank-account-access-management/ledgers-bank-account-access-repository/src/main/java/de/adorsys/ledgers/baam/db/repository/AuditorAccessRepository.java @@ -6,5 +6,5 @@ @Repository public interface AuditorAccessRepository extends JpaRepository { - // Additional query methods can be added here if necessary + }