Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous result element #38

Open
jan-dolejsi opened this issue Jun 1, 2022 · 1 comment
Open

Ambiguous result element #38

jan-dolejsi opened this issue Jun 1, 2022 · 1 comment

Comments

@jan-dolejsi
Copy link

jan-dolejsi commented Jun 1, 2022

It is hard and untidy to consume the result element, because in context of status: PENDING it is a string/URL, and in context of status: ok, it is a structure. I recommend putting the URL to a distinctly different element outside of the result field.

Here is my understanding, of what the returned json body semantic:
https://github.com/jan-dolejsi/pddl-planning-service-client/blob/main/src/PlannerPackagePreviewService.ts#L125

Consider this:

{
  "status": "PENDING",
  "check": "/check/......."
}

... vs ...

{
  "status": "ok",
  "result": {
   }
}
@haz
Copy link
Contributor

haz commented Jun 1, 2022

Will discuss this mainly in #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants