Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off histogram matching in registration? #767

Closed
cookpa opened this issue Jan 15, 2025 · 4 comments · Fixed by #768
Closed

Turn off histogram matching in registration? #767

cookpa opened this issue Jan 15, 2025 · 4 comments · Fixed by #768

Comments

@cookpa
Copy link
Member

cookpa commented Jan 15, 2025

As discussed here,

ANTsX/ANTs#368

histogram matching as originally implemented in ANTs registration is not very useful, but it is hard-coded into antspy registration.

Since we have a better version available in antspy (#607), should we turn it off in the registration pipeline?
@cookpa
Copy link
Member Author

cookpa commented Jan 15, 2025

Not wanting to derail #766 but it reminded me to bring this up

@ntustison
Copy link
Member

I would vote yes for removal.

@gdevenyi
Copy link

I vote yes

@cookpa cookpa linked a pull request Jan 17, 2025 that will close this issue
Turn off hard-coded histogram matching in registration #768
Merged
@cookpa
Copy link
Member Author

cookpa commented Jan 24, 2025

I made a small script that lets you see what the histogram matching actually does

https://github.com/cookpa/antsRegistrationPreprocDemo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn off hard-coded histogram matching in registration ANTsX/ANTsPy
3 participants
@ntustison @cookpa @gdevenyi