From 74dc47cd2853cf59c870ce44b9c2340c0c5be582 Mon Sep 17 00:00:00 2001
From: AWSHurneyt <hurneyt@amazon.com>
Date: Fri, 24 Jan 2025 15:24:35 -0800
Subject: [PATCH] Updated unit tests.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
---
 .../BucketSelectorExtAggregatorTests.kt       | 24 ++++++++++++++-----
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/alerting/src/test/kotlin/org/opensearch/alerting/aggregation/bucketselectorext/BucketSelectorExtAggregatorTests.kt b/alerting/src/test/kotlin/org/opensearch/alerting/aggregation/bucketselectorext/BucketSelectorExtAggregatorTests.kt
index 257a0a705..3dcc91647 100644
--- a/alerting/src/test/kotlin/org/opensearch/alerting/aggregation/bucketselectorext/BucketSelectorExtAggregatorTests.kt
+++ b/alerting/src/test/kotlin/org/opensearch/alerting/aggregation/bucketselectorext/BucketSelectorExtAggregatorTests.kt
@@ -102,10 +102,12 @@ class BucketSelectorExtAggregatorTests : AggregatorTestCase() {
                 iw.addDocument(doc)
             },
             Consumer { f: InternalFilters ->
+                val bucketSelectorIndices = f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices
                 assertThat(
-                    (f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices).bucketIndices[0],
+                    bucketSelectorIndices.bucketIndices[0],
                     CoreMatchers.equalTo(1)
                 )
+                assertEquals(BucketSelectorExtAggregationBuilder.NAME.preferredName, bucketSelectorIndices.writeableName)
             },
             fieldType, fieldType1
         )
@@ -162,10 +164,12 @@ class BucketSelectorExtAggregatorTests : AggregatorTestCase() {
                 iw.addDocument(doc)
             },
             Consumer { f: InternalFilters ->
+                val bucketSelectorIndices = f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices
                 assertThat(
-                    (f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices).bucketIndices.size,
+                    bucketSelectorIndices.bucketIndices.size,
                     CoreMatchers.equalTo(0)
                 )
+                assertEquals(BucketSelectorExtAggregationBuilder.NAME.preferredName, bucketSelectorIndices.writeableName)
             },
             fieldType, fieldType1
         )
@@ -183,10 +187,12 @@ class BucketSelectorExtAggregatorTests : AggregatorTestCase() {
                 iw.addDocument(doc)
             },
             Consumer { f: InternalFilters ->
+                val bucketSelectorIndices = f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices
                 assertThat(
-                    (f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices).bucketIndices[0],
+                    bucketSelectorIndices.bucketIndices[0],
                     CoreMatchers.equalTo(1)
                 )
+                assertEquals(BucketSelectorExtAggregationBuilder.NAME.preferredName, bucketSelectorIndices.writeableName)
             },
             fieldType, fieldType1
         )
@@ -226,10 +232,12 @@ class BucketSelectorExtAggregatorTests : AggregatorTestCase() {
                 iw.addDocument(doc)
             },
             Consumer { f: InternalFilters ->
+                val bucketSelectorIndices = f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices
                 assertThat(
-                    (f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices).bucketIndices.size,
+                    bucketSelectorIndices.bucketIndices.size,
                     CoreMatchers.equalTo(0)
                 )
+                assertEquals(BucketSelectorExtAggregationBuilder.NAME.preferredName, bucketSelectorIndices.writeableName)
             },
             fieldType, fieldType1
         )
@@ -270,10 +278,12 @@ class BucketSelectorExtAggregatorTests : AggregatorTestCase() {
                 iw.addDocument(doc)
             },
             Consumer { f: InternalFilters ->
+                val bucketSelectorIndices = f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices
                 assertThat(
-                    (f.buckets[0].aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices).bucketIndices[0],
+                    bucketSelectorIndices.bucketIndices[0],
                     CoreMatchers.equalTo(0)
                 )
+                assertEquals(BucketSelectorExtAggregationBuilder.NAME.preferredName, bucketSelectorIndices.writeableName)
             },
             fieldType, fieldType1
         )
@@ -318,10 +328,12 @@ class BucketSelectorExtAggregatorTests : AggregatorTestCase() {
                 iw.addDocument(doc)
             },
             Consumer { f: InternalFilter ->
+                val bucketSelectorIndices = f.aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices
                 assertThat(
-                    (f.aggregations.get<Aggregation>("test_bucket_selector_ext") as BucketSelectorIndices).bucketIndices[0],
+                    bucketSelectorIndices.bucketIndices[0],
                     CoreMatchers.equalTo(1)
                 )
+                assertEquals(BucketSelectorExtAggregationBuilder.NAME.preferredName, bucketSelectorIndices.writeableName)
             },
             fieldType, fieldType1
         )