Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important code which is not executed in tests #1007

Open
27 of 52 tasks
t-b opened this issue Jul 14, 2021 · 1 comment
Open
27 of 52 tasks

Important code which is not executed in tests #1007

t-b opened this issue Jul 14, 2021 · 1 comment
Labels
bug Something isn't working CodeQuality

Comments

@t-b
Copy link
Collaborator

t-b commented Jul 14, 2021

Latest coverage data: https://byte-physics.de/public-downloads/aistorage/transfer/report/coverage

Using UTF code coverage feature it was revealed that the following code paths are never executed:

  • Locked/unlocked indexing with TTL channels
  • OOD_CalculateOffsets the condition yoked || setNr < numSets - 1 is never true
  • ED_AddEntryToLabnotebook with finite tolerance
  • DQ_StopOngoingDAQHelper: if(IsDeviceActiveWithBGTask(panelTitle, TASKNAME_FIFOMON)) and if(!RA_IsFirstSweep(panelTitle)) are never true.
  • Add generic test code for excecuting the _GetHelp function of analysis functions, see Check help string analysis functions #1216
  • Not all branches of PSQ_EvaluateBaselineProperties are executed, see Feature/1386 add bessel filter chirp #1386
  • Get rid of MSQ_EvaluateBaselineProperties as it is not executed
  • MSQ_FastRheoEst: newDAScaleValue = DAScale[i] + stepSize[i] is never executed
  • SC_SpikeControl: The true path here is never hit
00000020|00000000|00000020|				if(SC_SkipsExhausted(minTrials, s.params))
________|________|________|					// if the minimum trials value has already reached the maximum
________|________|________|					// allowed trials, we are done and the set has not passed
  • HW_WriteDigital/HW_ReadDigital
  • HW_DisableYoking/HW_EnableYoking
  • DAP_FormatCommentString/DAP_AddUserComment
  • DAP_UnlockCommentNotebook/DAP_ClearCommentNotebook
  • DAP_DeleteStimulusSet
  • MIES_Dandi.ipf
  • DQ_GetNumDevicesWithDAQRunning
  • Add test override code to a wrapper function for GetKeyState so that DQ_STOP_REASON_ESCAPE_KEY can be tested as well.
  • DQS_StartDAQSingleDevice and aborting DC_Configure
  • DC_GetConfiguration Tests: Add ScaleZeroWithCycling #1410:
00001144|00000000|00001144|				if(scalingZero && (indexingLocked || !indexing) && setCycleCount > 0)
________|________|________|					DACAmp[i][%DASCALE] = 0
________|________|________|				endif
00000128|00000000|00000128|			if(powerSpectrum)
________|________|________|				DACAmp[i][%TPAMP] = 0
________|________|________|			endif
00000913|00000000|00000913|			if(V_Value != -1)
________|________|________|				return [1, V_row, V_col]
________|________|________|			endif
  • DC_CalculateChannelColumnNo with random acquisition, 3601294 (DAP_CheckProc_RandomRA: Fix random acquisition checkbox, 2023-05-22) was supposed to fix that but somehow didn't
  • EP_AddEpochsFromStimSetNote
00000406|________|________|			else
________|________|________|				DC_AddEpoch(panelTitle, channel, epochBegin, epochEnd, EPOCH_BASELINE_REGION_KEY, 2, lowerlimit = stimsetBegin, upperlimit = stimsetEnd)
________|________|________|			endif
  • EP_AddEpochsFromStimSetNote
412|________|________|________|            else

413|________|________|________|                tags = ReplaceStringByKey(EPOCH_SUBTYPE_KEY, "", EPOCH_BASELINE_REGION_KEY, STIMSETKEYNAME_SEP, EPOCHNAME_SEP)

414|________|________|________|                EP_AddEpoch(device, channel, epochBegin, epochEnd, tags, shortNameEpTypePTBaseline, 2, lowerlimit = stimsetBegin, upperlimit = stimsetEnd)
  • FindIndizes: prop branches
  • NWB_AppendStimset: custom waves are never written
  • NWB_WriteStimsetTemplateWaves with third party stimsets
  • NWB_LoadStimset: custom waves are never read
  • MIES_PressureControl.ipf
  • GetPopupMenuList/ParsePopupMenuValue with PGC_POPUPMENULIST_TYPE_BUILTIN
  • PGC_SetAndActivateControl: CONTROL_TYPE_VALDISPLAY/PGC_POPUPMENULIST_TYPE_BUILTIN/missing window
  • PGC_SetAndActivateControl: SetVariable see PGC_SetAndActivateControl: Enhance test coverage #1408
  • RA_StartMD/RA_Start: where numTotalSweeps == 1, see Tests: Add single/multi device tests with RA and a single sweep #1411
  • TP_ROAnalysis with buffer size > 1
  • Foreground DAQ
  • Foreground TP
  • AFH_CheckAnalysisParameter
855|________|________|________|            // non present required parameters are an error

856|________|________|________|            errorMessages[index++] = name + ": is required but missing"

857|________|________|________|            continue
  • BSP_ButtonProc_RestoreData
  • CA_DeleteCacheEntry/CA_OutputCacheStatistics
  • HW_NI_PrintPropertiesOfDevices
  • DAP_TurnOffAllChannels
  • DQ_ApplyAutoBias
334|________|________|________|        AI_UpdateAmpModel(device, "check_DatAcq_HoldEnable", headStage, value=1, sendToAll=0)

335|________|________|________|        AI_UpdateAmpModel(device, "setvar_DataAcq_Hold_IC", headstage, value=current * ONE_TO_PICO,sendToAll=0)
@t-b t-b added bug Something isn't working CodeQuality labels Jul 14, 2021
@t-b t-b changed the title Uncovered but important code Important code which is not executed in tests Jul 14, 2021
@t-b
Copy link
Collaborator Author

t-b commented Jun 3, 2022

Last update: 7d6c223 (Merge pull request #2279 from AllenInstitute/bugfix/2279-better-manual-installation-instructions, 2024-10-18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CodeQuality
Projects
None yet
Development

No branches or pull requests

1 participant