Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psx add more docu #1994

Closed
t-b opened this issue Feb 4, 2024 · 2 comments
Closed

psx add more docu #1994

t-b opened this issue Feb 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working documentation Miniature Analysis aka PSX PSP/PSC, part of SweepFormula Upgrade IVSCC NWB2 files facilitates mini analysis on IVSCC data and integration with IPFX

Comments

@t-b
Copy link
Collaborator

t-b commented Feb 4, 2024

image with different lo/hi values of deconv and other psx filter parameters

@t-b t-b added bug Something isn't working documentation Miniature Analysis aka PSX PSP/PSC, part of SweepFormula Upgrade IVSCC NWB2 files facilitates mini analysis on IVSCC data and integration with IPFX labels Feb 4, 2024
@t-b
Copy link
Collaborator Author

t-b commented Feb 9, 2024

psx: filterLow and filterHigh, used in PSX_FilterSweepData, passed to FilterIIR. It's help says

Create bandpass and bandreject filters by specifying both /HI and /LO. For a bandpass filter, set fLow >fHigh, and for a band reject filter, set fLow < fHigh.

and we enforce low > high so this is bandpass filter. WP: https://en.wikipedia.org/wiki/Band-pass_filter.

psxdeconvFilter: lowFreq and highFreq used in PSX_DeconvoluteSweepData, passed to FilterFIR, and we enforce

ASSERT(lowFrac < highFrac, "Expected a low pass filter with lowFrac < highFrac")

so this is a low-pass filter. WP: https://en.wikipedia.org/wiki/Low-pass_filter

@t-b t-b self-assigned this Feb 23, 2024
@t-b
Copy link
Collaborator Author

t-b commented Jan 27, 2025

Already done in #2023.

@t-b t-b closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Miniature Analysis aka PSX PSP/PSC, part of SweepFormula Upgrade IVSCC NWB2 files facilitates mini analysis on IVSCC data and integration with IPFX
Projects
None yet
Development

No branches or pull requests

1 participant