Prepare release notes #2266
Merged
Prepare release notes #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the function sets the flag checkWaveType to check the type when the type is specified the set action was assigning !!checkWaveType for that case that results in 0, as checkWaveType was only initialized by Igor Pro itself to 0. Changed such that checkWaveType is set to 1 when expectedWaveType was specified.
The INFO function is only available when igortest is included. There are several ways to achieve the validity on compilation: 1. Check if the function exists with #ifdef (as done here) 2. Determining the function dynamically through FUNCREF 3. Conditionally recompile with dynamically added defines 4. Provide a "null" function in MIES with the same signature. Disadvantages: 1. does not scale well, only applies to a single function 2. needs a prototype function in MIES and will fail if function signature changes in igortest 3. Allows larger codeblocks with external functions but does not scale well and rather slow 4. needs like 2 a function with the same signature as in igortest We decided for 1 as it seems to impose the smallest disadvantages
timjarsky
reviewed
Sep 25, 2024
timjarsky
reviewed
Sep 25, 2024
timjarsky
reviewed
Sep 25, 2024
t-b
force-pushed
the
feature/2266-release-notes
branch
from
282e52b to
6258cf9
Compare
timjarsky
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.