Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to toggle on hold/release. #19

Open
phuein opened this issue Jun 26, 2021 · 2 comments
Open

Add option to toggle on hold/release. #19

phuein opened this issue Jun 26, 2021 · 2 comments

Comments

@phuein
Copy link

phuein commented Jun 26, 2021

Hi. Just started using the app, and it's working great. Would it be possible to add an option that toggles mic muting on key hold and toggles it back on key release?

Would be extra cool if it detected when the toggle key is being held for over 500ms and triggers this behavior automatically.

@Anc813
Copy link
Owner

Anc813 commented Jun 26, 2021

@phuein it similar to push to talk feature #9
Unfortunately, this project uses Shortcut library https://github.com/AlexArchive/Shortcut
And it can only notify about shortcut press event, not keyup or keydown (keyup and keydown are required to capture hold/release events)

@phuein
Copy link
Author

phuein commented Jun 26, 2021

Yeah, the Shortcut library was last updated on Dec 19, 2014, so not much to work with there. I implemented this with a workaround. Far from perfect, but I didn't see myself sending a PR to a much older project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants