-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to mongodb-memory-server 9.0.0 #13764
Conversation
i still dont know what the problem is, but my theories are:
|
if all tests run, it is mostly consistent which tests fail, the problem is that if they (the test file) is run individually, all tests of that run suite pass, but there will still be a another finding: mongoose/test/model.populate.setting.test.js Lines 117 to 121 in 57b6eab
this test fails once it its the it also "clogs up" any operation that comes after it (likely because it is not cleared by mongodb?) also (which is likely related to the previous issue), deno seemingly messes up some kind of stream, error:
|
i just found denoland/deno#19831, which is the exact issue this PR is having, greatly it is already fixed (by denoland/deno#20314), downside is that no deno version has been released yet and only PR Blocked until deno releases a version with this fix |
deno 1.37.0 released, which included the fix, have pushed the update and the tests seem to be passing now again without problems, will clean-up and update PR tomorrow (or something) but somehow there are no tests on this PR itself, only tests on the commit (on the fork) |
9607781
to
d951be5
Compare
updated PR to be based on latest master and cleaned it up *also accidentally rebased once on 8.0 instead of master this PR now also includes a fix for test file |
be41538 is the final test before releasing mongodb-memory-server 9, to ensure it also works outside of its own test-suite in its current state will clean this PR up once it is released |
before being merged i would like to know if d8e1f4f is the best way or if someone maybe knows where the problem there is |
just for reference because it does not show up here, @vkarpov15 wrote on d8e1f4f:
|
Updated to use just as a note, i could not just do the |
changed base branch to 7.x (because of 8.0 merge), if this branch should not get merged over to 8.x, i will make another PR for that. |
@vkarpov15 just as a reminder, this PR is ready to be merged. it is targeting 7.x as the PR had been opened before 8.0 was even merged, and changed to 7.x (instead of staying 8.0) because this means mongodb 7.0 can be tested in mongoose 7.x and because the dependencies (nodejs and mongodb and others) align. if wanted i could also re-target to only have this updated in 8.x.. also if wanted i could rebase this PR to remove the merge commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to review and merge this. LGTM 👍
Summary
This PR upgrades
mongodb-memory-server
to9.0.0
(-beta.2
), but also does:7.0.0
as a test (because mms more probably supports it with 9.0.0)Currently known problems:
deno really does not like the new MMS (mongodb?) version, constant
Server selection timed out
and locally many test fail too.also in a debug run in CI it seems like the server somehow has a lot of failed hearbeats, and i dont understand why
even when testing locally against a mongodb docker container (via
MONGOOSE_TEST_URI
), those same tests fail and the final error logged also isServer selection timed out after 30000 ms