From d0d2b288ed9518abc2256dadc0ab3f39c0340add Mon Sep 17 00:00:00 2001 From: Daniel Diaz <39510674+IslandRhythms@users.noreply.github.com> Date: Thu, 25 Jan 2024 11:46:13 -0500 Subject: [PATCH 1/3] add type for createCollections --- test/types/connection.test.ts | 2 ++ types/connection.d.ts | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/test/types/connection.test.ts b/test/types/connection.test.ts index 01e42bec123..4518101c44e 100644 --- a/test/types/connection.test.ts +++ b/test/types/connection.test.ts @@ -20,6 +20,8 @@ conn.readyState === 99; expectError(conn.readyState = 0); +expectError(conn.createCollections()); + expectType(new Connection()); expectType>(new Connection().asPromise()); diff --git a/types/connection.d.ts b/types/connection.d.ts index a4f0f23eb8f..1fb7ba7aa9c 100644 --- a/types/connection.d.ts +++ b/types/connection.d.ts @@ -81,6 +81,11 @@ declare module 'mongoose' { */ createCollection(name: string, options?: mongodb.CreateCollectionOptions): Promise>; + /** + * https://mongoosejs.com/docs/api/connection.html#Connection.prototype.createCollections() + */ + createCollections(continueOnError?: boolean): Promise>; + /** * Removes the model named `name` from this connection, if it exists. You can * use this function to clean up any models you created in your tests to From 122734693cbbd2125d58125d03da8b1342441e99 Mon Sep 17 00:00:00 2001 From: Daniel Diaz <39510674+IslandRhythms@users.noreply.github.com> Date: Thu, 25 Jan 2024 14:58:46 -0500 Subject: [PATCH 2/3] remove test --- test/types/connection.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/test/types/connection.test.ts b/test/types/connection.test.ts index 4518101c44e..3686e19d0c3 100644 --- a/test/types/connection.test.ts +++ b/test/types/connection.test.ts @@ -20,7 +20,6 @@ conn.readyState === 99; expectError(conn.readyState = 0); -expectError(conn.createCollections()); expectType(new Connection()); expectType>(new Connection().asPromise()); From 56f0515a83e4edb966e626df03e3b4b7b6251e90 Mon Sep 17 00:00:00 2001 From: Valeri Karpov Date: Thu, 25 Jan 2024 15:18:54 -0500 Subject: [PATCH 3/3] types: correct type defs for createCollections() --- test/types/connection.test.ts | 3 +++ types/connection.d.ts | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/test/types/connection.test.ts b/test/types/connection.test.ts index 3686e19d0c3..93c3fc6c0d8 100644 --- a/test/types/connection.test.ts +++ b/test/types/connection.test.ts @@ -20,6 +20,9 @@ conn.readyState === 99; expectError(conn.readyState = 0); +expectType>>>( + conn.createCollections() +); expectType(new Connection()); expectType>(new Connection().asPromise()); diff --git a/types/connection.d.ts b/types/connection.d.ts index 1fb7ba7aa9c..35714b13c8d 100644 --- a/types/connection.d.ts +++ b/types/connection.d.ts @@ -84,7 +84,7 @@ declare module 'mongoose' { /** * https://mongoosejs.com/docs/api/connection.html#Connection.prototype.createCollections() */ - createCollections(continueOnError?: boolean): Promise>; + createCollections(continueOnError?: boolean): Promise>>; /** * Removes the model named `name` from this connection, if it exists. You can