Add username/password fallback option for login #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@charliescheer changes look great!!
Two minor notes:
Header
- Launch Simplenote
- Click on
Log In - Click on
Log in manually
The UI displays Email + Password fields, but the header reads Enter the password for the account.
Perhaps in this flow we should display no header?
Preloading
- Launch Simplenote
- Click on
Log In - Enter your email
- Click on
Log in manually
As a result, the email field will be empty. We should probably preserve whatever you've typed in (3).
|
Fixed both. Thanks @jleandroperez |
jleandroperez
approved these changes
Sep 12, 2024
|
I don't mind. Thank you @jleandroperez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
We have received some feedback about the new login flow that some people thought we had dropped the login with password option. We have decided to add a button on the login with email page where users can choose to login with email and password instead. This surfaces this option for users who wants it and doesn't require receiving the login email to before you can enter your password. This also helps in circumstances where GAE might be down and login with email isn't possible.
Test
Smoke test the magic links flow and make sure it still looks as expected
Review
(Required) Add instructions for reviewers. For example:
Release