Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: Required parameter $refund_data follows optional parameter $bco_transaction_id #39

Open
DanielMarklund opened this issue Aug 18, 2022 · 0 comments

Comments

@DanielMarklund
Copy link

DanielMarklund commented Aug 18, 2022

Hi! A minor issue that I'd prefer to be fixed, as it's clogging up error logs when logging depreciations.

Versions:
PHP: 8.0.0
Wordpress: 6.0.1
WooCommerce: 6.8.0
Billmate Order Management: 1.2.2

Error message:

( ! ) Deprecated: Required parameter $refund_data follows optional parameter $bco_transaction_id in *****/wp-content/plugins/billmate-order-management-for-woocommerce/classes/class-bom-api.php on line 65
Call Stack
#	Time	Memory	Function	Location
1	16785938047.3599	367824	{main}( )	.../index.php:0
2	16785938047.3599	368232	require( *****/wp-blog-header.php )	.../index.php:17
3	16785938047.3599	368952	require_once( *****/wp-load.php )	.../wp-blog-header.php:13
4	16785938047.3599	369648	require_once( *****/wp-config.php )	.../wp-load.php:50
5	16785938047.3599	378720	require_once( *****/wp-settings.php )	.../wp-config.php:80
6	16785938047.3599	9562616	do_action( )	.../wp-settings.php:461
7	16785938047.3599	9562992	WP_Hook->do_action( )	.../plugin.php:476
8	16785938047.3599	9562992	WP_Hook->apply_filters( )	.../class-wp-hook.php:331
9	16785938047.3599	10146728	Billmate_Order_Management_For_WooCommerce->init( )	.../class-wp-hook.php:307
10	16785938047.3599	10167584	Billmate_Order_Management_For_WooCommerce->include_files( )	.../billmate-order-management-for-woocommerce.php:98

From class-bom-api.php:

	/**
	 * Credit Billmate Payment.
	 *
	 * @param string $bco_transaction_id The Billmate transaction id.
	 * @param string $refund_data The refund data.
	 * @return mixed
	 */
	public function request_credit_payment( $bco_transaction_id = '', $refund_data ) {
		$request  = new BOM_Request_Credit_Payment();
		$response = $request->request( $bco_transaction_id, $refund_data );
		return $response;
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant