above: add package. #4465
Open
above: add package. #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraj
requested changes
Feb 12, 2025
Comment on lines
+19
to
+23
| pkgver() { | ||
| cd $pkgname | ||
|
|
||
| echo $(git rev-list --count HEAD).$(git rev-parse --short HEAD) | ||
| } |
There was a problem hiding this comment.
Suggested change
| pkgver() { | |
| cd $pkgname | |
| echo $(git rev-list --count HEAD).$(git rev-parse --short HEAD) | |
| } | |
| pkgver() { | |
| cd $pkgname | |
| ( set -o pipefail | |
| git describe --long --tags --abbrev=7 2>/dev/null | | |
| sed 's/\([^-]*-g\)/r\1/;s/-/./g' || | |
| printf "%s.%s" "$(git rev-list --count HEAD)" \ | |
| "$(git rev-parse --short=7 HEAD)" | |
| ) | |
| } |
ref. https://github.com/BlackArch/blackarch-pkgbuilds/blob/master/PKGBUILD-generic-git
there are git tags https://github.com/casterbyte/Above/tags
| 'blackarch-fingerprint' 'blackarch-networking' 'blackarch-recon' | ||
| 'blackarch-voip') | ||
| url='https://github.com/casterbyte/Above' | ||
| license=('GPL3') |
There was a problem hiding this comment.
SPDX identifiers please https://spdx.org/licenses/
| cd /usr/share/above | ||
| python -m venv venv | ||
| source venv/bin/activate && | ||
| pip install --isolated --root="/usr/share/above" --prefix='venv' \ |
There was a problem hiding this comment.
the dependencies look simple, why use a virtual env? https://github.com/casterbyte/Above/blob/4789d6eed0dce7aaf6103852fe7915c6e1d56a5d/setup.py#L16-L18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added above, a network sniffer.