From dfc84c54d0724fc9cf7aaeaf3fe05fbb789744bc Mon Sep 17 00:00:00 2001 From: christian Date: Fri, 9 Oct 2020 12:53:26 -0500 Subject: [PATCH] Add CHANGELOD.md --- CHANGELOG.md | 1 + comms/src/blazingdb/transport/io/reader_writer.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 79a3bd668..321155371 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,7 @@ - #1057 Fixed issue with concat all in concatenating cache - #1007 Fix arrow and spdlog compilation issues - #1068 Just adds a docs important links and avoid the message about filesystem authority not found +- #1074: Remove lock inside grow() method from PinnedBufferProvider # BlazingSQL 0.15.0 (August 31, 2020) diff --git a/comms/src/blazingdb/transport/io/reader_writer.cpp b/comms/src/blazingdb/transport/io/reader_writer.cpp index ee0e6dbc2..f201d45e6 100644 --- a/comms/src/blazingdb/transport/io/reader_writer.cpp +++ b/comms/src/blazingdb/transport/io/reader_writer.cpp @@ -68,6 +68,7 @@ PinnedBuffer *PinnedBufferProvider::getBuffer() { // Will create a new allocation and grow the buffer pool with this->numBuffers/2 new buffers +// Its not threadsafe and the lock needs to be applied before calling it void PinnedBufferProvider::grow() { PinnedBuffer *buffer = new PinnedBuffer(); buffer->size = this->bufferSize;