New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: custom nonce #15

Open

reslear opened this issue Oct 3, 2024 · 9 comments

Contributor

reslear commented Oct 3, 2024 •

edited

Loading

implement feature for setting custom nonce:

google/GoogleSignIn-iOS#402
or https://developer.android.com/identity/sign-in/credential-manager-siwg#set-nonce

// draft 
const res = await SocialLogin.login({
  provider: 'google',
  options: {
    scopes: ['email', 'profile'],
    nonce: 'ABCD'
  },
});

Contributor

riderx commented Oct 4, 2024

Nonce i can add :)

Contributor

riderx commented Oct 4, 2024

It's not release yet on IOS : https://developers.google.com/identity/sign-in/ios/release
I Added in on android

Contributor Author

reslear commented Oct 4, 2024 •

edited

Loading

good, we'll be waiting ios release)

Contributor

riderx commented Oct 4, 2024 •

edited

Loading

Trying my best to release, but Facebook fucked their SDK

This comment was marked as off-topic.

Sign in to view

Contributor

riderx commented Oct 4, 2024

not sure to what you mean can you share doc?

This comment was marked as off-topic.

Sign in to view

Contributor Author

reslear commented Dec 10, 2024

hi @riderx https://github.com/google/GoogleSignIn-iOS/releases/tag/8.1.0-vwg-eap-1.0.0 released with this changes

Contributor

riderx commented Dec 10, 2024

nice ! thanks @WcaleNieWolny will have a look this week after we finish something for our main project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment