-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom sheet ui for google auth on android #45
Comments
Regarding the new UI implementation request: I understand this was a deliberate design choice, but I believe there's value in reconsidering: Benefits
SuggestionCould we consider adding this as an optional UI variant? This would:
I'm willing to help with implementation/documentation if you're open to discussing this approach. What are your thoughts on exploring this as a configurable option? |
I am more than happy to welcome a PR, but only if this "one tap" api works across all platforms (iOS, web, Android) I know that it's possible to do |
I appreciate your openness to the PR, but I should mention that iOS's
security model may make a true 'one tap' API impossible on that platform.
Would you still be interested in implementing this for Android/web users,
with a fallback flow for iOS?
That way we could improve the experience for the majority of users while
maintaining functionality for iOS
…On Sun, 3 Nov 2024, 20:49 WcaleNieWolny, ***@***.***> wrote:
I am more than happy to welcome a PR, but only if this "one tap" api works
across all platforms (iOS, web, Android)
I know that it's possible to do one tap on the web and on Android, but I
am not sure about iOS
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGYWBOL3A2EPULAVKBCVALZ6ZV2NAVCNFSM6AAAAABRADDMD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGUZTQNJWGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Can you link the doc of this new modal? |
Doc for what? for the one tap? https://developer.android.com/identity/sign-in/credential-manager-siwg To trigger Google One Tap flow, use GetGoogleIdOption instead of GetSignInWithGoogleOption |
@yakovyarmo have you tried the plugin? |
ok no you where right, i added newUI in option of login put it to true to test the new UI |
@riderx one of my first commits back when this plugin was in its infancy was nuking one-tap from Android. Unfortunately, By far the biggest issue that I faced back then was the requirement of using the device's system accounts. If the user is not logged in, this one-tap API will not allow him or her to add a new Google account. It was also inconsistent with iOS and the web. I am of the firm belief that providing an option for this new UI is in the best interests of the users as long as it is not default option |
with an option i agree it good. |
Can I offer just to add an option to the google login?
or just a new provider?
|
@riderx I just remembered why I nuked the one-tap API. It's incredibly annoying to use, and frankly I struggle to get it to work |
This darn API is nothing but pain. It's almost impossible to get past the |
You don’t need to handle every caee if there is a demo showing the base the comunity can improve it |
May be you want me to help with it? |
Sure, here are the changes: #75 |
It worked on my android device (if I remove the comments) |
I made some changes to the file, |
yes please |
But I have no permission to push |
fork and do a PR |
Just did. |
You wait. Merging anything into main is blocked for the next couple of days because I am porting development into main |
Hi, what is the status for the merge? |
How can we show the new ui for goole auth on android?
The text was updated successfully, but these errors were encountered: