Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating the latest fixes from main to development #79

Open
solartune opened this issue Dec 4, 2024 · 4 comments
Open

Migrating the latest fixes from main to development #79

solartune opened this issue Dec 4, 2024 · 4 comments

Comments

@solartune
Copy link

Hey there, I started using the 0.0.69-alpha.9 version of the plugin as it fixed an issue with Google sign in for me but I noticed that in some cases Apple Sign In has stopped working properly on ios. To be more specific, I'm not getting user's data like their email and name. All of those are just empty strings.
I had this issue before when, I think I was on the 0.0.69 version and then I updated the plugin to 0.0.76 and the issue was gone. I suspect that this commit fixed it in the main branch but am not 100% sure.
And now when I'm using the alpha version, this issue is back.

So my question is if you have plans on migrating some or all of the fixes from the main branch to the development one? I suspect there could be conflicts as the alpha version seems to be heading in a different direction.

@WcaleNieWolny
Copy link
Contributor

I would like to see development merged into main, but that is slightly difficult.

@WcaleNieWolny
Copy link
Contributor

Update: Me and @riderx have finally found a consensus. Development will NOT get merged into main. Instead, a new branch will be created from main, and the changes from development will be PORTED there.

If needed, a migration guide will be written explaining the migration AWAY from the development version.

@solartune
Copy link
Author

Oh, that's awesome! If it won't be a bother to you, please do post an update here when this happens! 🙂

@riderx
Copy link
Contributor

riderx commented Dec 10, 2024

We released the first version coming from this change in 0.0.77-alpha.1 documentation is coming soon to migrate to it, if all user of dev migrate well and it work for them we will release a v1 version in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants