Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: implement addScopes method #9

Open
reslear opened this issue Sep 26, 2024 · 10 comments
Open

feature request: implement addScopes method #9

reslear opened this issue Sep 26, 2024 · 10 comments

Comments

@reslear
Copy link
Contributor

reslear commented Sep 26, 2024

you need to take care of the api for future:
https://react-native-google-signin.github.io/docs/original#addscopes
@riderx It's also a great project for inspiration

@riderx
Copy link
Contributor

riderx commented Sep 26, 2024

Not sure what you mean here :)
We just commit our implementation have a look

@riderx riderx closed this as completed Oct 3, 2024
@reslear
Copy link
Contributor Author

reslear commented Oct 3, 2024

hi @riderx, yes but i mean add method addScopes:

// draft 

const res = await GoogleSignin.addScopes({
  provider: 'google',
  scopes: ['https://www.googleapis.com/auth/user.gender.read'],
});

@reslear reslear changed the title feature request: addScopes api feature request: implement addScopes method Oct 3, 2024
@riderx
Copy link
Contributor

riderx commented Oct 3, 2024

We use credential manager, the new library who use the webID it doesn't seems to have scope available in this setup
https://developer.android.com/identity/sign-in/credential-manager-siwg

@riderx
Copy link
Contributor

riderx commented Oct 4, 2024

This is the deprecated SDK we don't use it.
For now, the new doc is a mess and misses many things, like login users who don't have account on the mobile won't work.
Here is the whole doc if you want to look for it:
https://developer.android.com/jetpack/androidx/releases/credentials
I wish I missed it

@reslear
Copy link
Contributor Author

reslear commented Oct 4, 2024

@riderx good, maybe reopen issue?
would be good for future or web version

@riderx riderx reopened this Oct 4, 2024
@WcaleNieWolny
Copy link
Contributor

I believe that using addScopes MIGHT be possible using authorization

@WcaleNieWolny
Copy link
Contributor

@reslear I found an example repo: here.

I was able to implement a small PoC with the addScopes. I believe that it can be implemented

@riderx
Copy link
Contributor

riderx commented Oct 6, 2024

Great catch !

@Saqib92
Copy link

Saqib92 commented Nov 18, 2024

I think scopes are working now.
"@capgo/capacitor-social-login": "^0.0.68-alpha.7",

#46 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants