Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Units of Measure #145

Open
fosterlynn opened this issue Oct 28, 2024 · 4 comments
Open

Configurable Units of Measure #145

fosterlynn opened this issue Oct 28, 2024 · 4 comments
Assignees

Comments

@fosterlynn
Copy link
Member

fosterlynn commented Oct 28, 2024

3 days

CRUD UI (skip delete), show override if exists

Think: add currency flag?; use facet?; search box with type ahead - csv file?; needs spec

What is in hrea? probably label and symbol

Configure Units, pick from OM list, add user overrides. To make it easier, we could require the user to enter the OM unique unit id. We'd have to help them with that, which is fine for awhile.

@fosterlynn
Copy link
Member Author

Switching to "other networks" milestone, probably can get away without it for now.

@fosterlynn
Copy link
Member Author

fosterlynn commented Nov 19, 2024

I'm realizing we should get enough of this done to avoid a data conversion later. That means we need at least the eventual proper id referenced by all the hasUnit properties.

So I'm moving it to the Planning milestone.

Minimal implementation [EDITED 12/5]:

  • Here's the current VF schema
    Screenshot from 2024-12-05 11-32-11
    I'm not sure what is now in hREA, but minimally we'll want omUnitIdentifier (simple string), label, overrideLabel. I don't think we are using symbol anywhere, so we can skip that unless we are. But if it is quick, let's just put all of the above in, for future use.
  • List page with modal add and edit for just the three above. It can go in the upper right dropdown menu, "Units". Modal for (at least) the 3 listed above.
  • Change wherever in the app is using units to use the new data store, not an existing hard-coded list, if that is how it is. Show the override label in dropdowns and displays.

Here's the CFN data, not that it necessarily matters for adding the page. but fyi to test:
id: one, label: one, override: ' ' (a space, or whatever will work for that)
id: poundAvoirdupois, label: pound (avoirdupois), override: pound

@LeosPrograms LeosPrograms added the review Ready for review label Dec 6, 2024
@fosterlynn fosterlynn removed the review Ready for review label Jan 7, 2025
@fosterlynn fosterlynn removed this from the Planning ready to use milestone Jan 7, 2025
@fosterlynn
Copy link
Member Author

This still needs something else, but it works as we decided. I took it out of the milestone, it can sit for a while. The problem is that on "one" we usually want to see what it is on the dropdown when picking it, and having it blank is confusing; but when just displayed on a report or something, the blank is best. TBD.

@fosterlynn
Copy link
Member Author

One other addition. Right now, we are "hard-selecting" certain units in certain places, notably USD for prices, pound for most other places. Fairly soon, we'll need to make all units available in all unit dropdowns, or have some other method to limit them as it makes sense.

In NRP, we had an elaborate template scheme that included limiting dropdowns by facet values. But even the person who was the most knowledgeable, and responsible for setting these things up, couldn't really understand how it all worked. I'll think about how to make it simpler. It's possible, all we really need for the foreseeable future is currencies and non-currencies, don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants