Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning UI: Notification symbols or colors #68

Open
fosterlynn opened this issue Dec 13, 2023 · 8 comments
Open

Planning UI: Notification symbols or colors #68

fosterlynn opened this issue Dec 13, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@fosterlynn
Copy link
Member

fosterlynn commented Dec 13, 2023

Needs spec

When there is an issue in the plan, at least supply not meeting demand, although there may be others, we could flag the issue visually and/or provide a note.

Possibly an overage, to note inventory will be created.

Needs more definition, but would be great to get into Phase 2, good demo item.

@fosterlynn fosterlynn added the prioritize? Should this be prioritized? label Jan 16, 2024
@fosterlynn fosterlynn added this to the Phase 2 milestone Feb 28, 2024
@fosterlynn
Copy link
Member Author

fosterlynn commented Feb 28, 2024

I'm putting this into phase 2, since I think @leo started working on it. If it is much work, we can drop it off, or move it to lower priority for the phase. The only thing for phase 2 would be if there isn't enough quantity of a resource specification in a commitment (or an offer if at the beginning) to feed the next commitment.

If a problem, make the commitment that can't be fulfilled red, as discussed.

@fosterlynn fosterlynn removed the prioritize? Should this be prioritized? label Feb 28, 2024
@fosterlynn
Copy link
Member Author

@LeosPrograms added one notification, see #96 (comment). This is good for now, for demo purposes. Not closing, because there will be others they want, but taking out of phase 2 milestone.

@fosterlynn fosterlynn removed this from the Phase 2 milestone Mar 1, 2024
@fosterlynn fosterlynn added the prioritize? Should this be prioritized? label Jul 2, 2024
@fosterlynn fosterlynn added this to the Coordinate during season milestone Jul 2, 2024
@fosterlynn fosterlynn removed the prioritize? Should this be prioritized? label Oct 18, 2024
@fosterlynn
Copy link
Member Author

fosterlynn commented Jan 10, 2025

I think we only need one notification, and it should work pretty much like the one on offers works: they don't have enough to do what they want to do, except within the production plan part, not offers. We could start with just output to input, although if input to output is easy to add, let's do both.

@LeosPrograms
Copy link
Collaborator

How does this work if existing inventory has been accounted for when creating the plan? It will show an overage when there isn't actually one. It could account for inventory, but that gets complex since we don't technically know which inventory was allotted where.

@LeosPrograms LeosPrograms added the review Ready for review label Feb 10, 2025
@fosterlynn
Copy link
Member Author

Getting an odd result:

Image

On the Combine Fiber stage, some of the outputs have a deficit notification, but there is no apparent reason they should. The recipes look OK to me, qty 1 on both input and output.

@fosterlynn fosterlynn removed the review Ready for review label Feb 11, 2025
@fosterlynn
Copy link
Member Author

fosterlynn commented Feb 11, 2025

More odd results:

Image

Ship Brown Alpaca Dirty should be showing notification 79 not enough to dropoff 80. Are we for pickup/dropoff looking for the same quantity for the same resource?

On scouring, I changed Brown Alpaca Clean to 100, it doesn't know that is too much from Brown Alpaca Dirty 78. Are we using the recipe?

(Apologies if I'm not remembering all the conversations.)

@LeosPrograms LeosPrograms added the review Ready for review label Feb 13, 2025
@fosterlynn fosterlynn removed the review Ready for review label Feb 13, 2025
@fosterlynn
Copy link
Member Author

I think we discussed that you haven't done input to output (forward) notifications, right? Because it would involve recipes? Otherwise this is looking really great!!

Leaving it open for now until we decide. I think it isn't super pressing, but I'd like to see what Laura and Evan think. I'll take the "next" off for now.

@fosterlynn fosterlynn added enhancement New feature or request and removed next labels Feb 13, 2025
@fosterlynn
Copy link
Member Author

Also, reminder to try bolding the notifications and we'll see if that green shows up better. Just that small thing I would put a "next" on.

Alternatively, I suppose we could do something like a red or green background to that text, like a hilighter. Whatever you think looks best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants