Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS REVIEW] Improve description in examples #9

Closed
finsberg opened this issue Nov 4, 2024 · 3 comments
Closed

[JOSS REVIEW] Improve description in examples #9

finsberg opened this issue Nov 4, 2024 · 3 comments

Comments

@finsberg
Copy link

finsberg commented Nov 4, 2024

I must first say that I really like the way you have created the examples. It is really cool with both the pyvista integration and the "Download buttons" at the end. Really nice job!

I think however that some of the examples could be improved by providing some more text explaining the different examples, preferable with the necessary mathematical background and references to papers. For example in Displacement control there are not really any text explaining what this example is about, and it seems to be some headings and text that are copy-pasted from other examples.

Instead of creating a separate issue for each example I create this one as a general issue for all of them, and then you can go through the examples and make sure that each example reads as a coherent piece of text.

This issue is related to the review here: openjournals/joss-reviews#7307

@CastillonMiguel
Copy link
Owner

CastillonMiguel commented Nov 15, 2024

I’m currently working on revising the examples and adding more detailed text, including necessary references and a clearer explanation of each example's purpose.
To keep track of the progress, I’m planning to address each examples section , and here’s a list of sections that I’ve revised or am working on revising:

I’ll update the examples to ensure they form coherent, self-contained explanations.
Thanks again for your input!

edit: I’ve updated the GmshGeoFiles section
edit2 : I’ve updated the PhaseFieldFracture/Fatigue section

@finsberg
Copy link
Author

Looks very good! A few minor things

  • The plot at the end here is not showing.
  • Some text on this page looks now well formatted.

@CastillonMiguel
Copy link
Owner

Thanks for the feedback! I’ve resolved the plot display issue and improved text formatting in that file and across other related files for better readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants