Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daylight savings time issue #89

Open
dhanadhan opened this issue Nov 6, 2024 · 4 comments
Open

Daylight savings time issue #89

dhanadhan opened this issue Nov 6, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@dhanadhan
Copy link

dhanadhan commented Nov 6, 2024

Last week we changed our clocks to 1 hour back and all my reminders lost an hour too. For example, 2:00 PM repeated daily reminder changed to 1:00PM and it was sending me reminders at 1:00PM which is an hour early.

I am using the TZ=America/Los_Angeles environment variable with the docker container. The server I run this container on had the correct time. To fix this issue, I had to manually update all my repeated reminders to +1 hour. Not sure where the issue is, but I guess you can't test this until the next time change occurs?

@dhanadhan dhanadhan added the bug Something isn't working label Nov 6, 2024
@dhanadhan dhanadhan changed the title Daylight savings didn't work Daylight savings time issue Nov 6, 2024
@Casvt Casvt added this to MIND plans Nov 7, 2024
@Casvt Casvt moved this to Handled Soon in MIND plans Nov 7, 2024
@dviry
Copy link

dviry commented Nov 9, 2024

Just to add my feedback here - IMO it's not just daylight saving time - but a wrong stored value/calculation:

  1. my server is running in TZ Europe/Vienna (GMT+1).
  2. creating a reminder in the UI for 10.Nov.2024 11:00
  3. shows in the log setting reminder to 1731229200 unix time

Yet that epoch time is wrong - from epochconverter

GMT: Sunday, November 10, 2024 9:00:00 AM
Your time zone: Sunday, November 10, 2024 10:00:00 AM [GMT+01:00]

This is quite a serious bug for a time-based Reminder service :(

EDIT
setting my server's TZ to Etc/GMT still shows the wrong time in the UI (+1) but at least it fires the reminder at the correct time. So maybe it's just an issue in the UI (is it considering the TZ setting at all?)...
BTW you might consider having the TZ setting PER USER instead of globally - albeit that will add even more complexity...

@Casvt
Copy link
Owner

Casvt commented Nov 9, 2024

It converts the time to UTC, so that's the epoch time you see. Check that the timezone is set correctly for the container and that in the user settings, the locale is set correctly.

@dviry
Copy link

dviry commented Feb 10, 2025

I have tried setting the container to Europe/Vienna, and the locale to DE-AT. It still does not work... Any further ideas?

Thanks

@dhanadhan
Copy link
Author

Well, it happened again! We changed our clock to 1 hour ahead yesterday. All my repeated reminders also changed 1 hour ahead. That means I got notifications 1 hour after what was originally set. For example, a reminder set for 9:00 PM prior to changing the clock is now showing up as 10:00 PM reminder. Is there a fix for this other than manually updating the time on all repeated reminders? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Handled Soon
Development

No branches or pull requests

3 participants