Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck Endpoint #91

Open
DANW999 opened this issue Feb 3, 2025 · 5 comments
Open

Healthcheck Endpoint #91

DANW999 opened this issue Feb 3, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@DANW999
Copy link

DANW999 commented Feb 3, 2025

Is your feature request related to a problem? Please describe.
No, just a feature that would be handy.

Describe the solution you'd like
Could we add a health check endpoint in the API that could be probed at all? Currently I use the default home page to probe it but I have found this can be unreliable as Mind has crashed before behind the scenes yet the homepage was still up.

Additional context

@DANW999 DANW999 added the enhancement New feature or request label Feb 3, 2025
@Casvt
Copy link
Owner

Casvt commented Feb 3, 2025

There's no scenario where MIND could go wrong and it being acceptable, so any errors should simply be fixed. Do you have logs of the error?

@DANW999
Copy link
Author

DANW999 commented Feb 4, 2025

Unfortunately, this was a little time back so no. But there was an error. The homepage was working but actually logging in had stopped. I restarted the container and it was working again and all the reminders that had been missed came through instantly. I was not alerted that Mind was down because my monitoring system curls the homepage URL, so as far as it was concerned it was all working.

@Casvt
Copy link
Owner

Casvt commented Feb 5, 2025

Hmm sounds like the thread that handles the sending of reminders on time crashed when handling one of the reminders. I could refactor it so that it always stays alive, even when an error occurs. The error should of course be fixed, but at least operation is continued.

@DANW999
Copy link
Author

DANW999 commented Feb 19, 2025

Right, in the meanwhile I have established that monitoring the /api/settings path suffices since it does not need password auth.

@DANW999
Copy link
Author

DANW999 commented Feb 19, 2025

So maybe nothing further is needed on this suggestion? Since /api/settings acts like a health path anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants