Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug (core): pop-button is not display when outlined & disabled are true #27

Closed
3 tasks done
Sukaato opened this issue Aug 31, 2024 · 0 comments · Fixed by #33
Closed
3 tasks done

bug (core): pop-button is not display when outlined & disabled are true #27

Sukaato opened this issue Aug 31, 2024 · 0 comments · Fixed by #33
Assignees
@Sukaato
Labels
bug Something isn't working package: core @poppy-ui/core package related
Milestone
v1.0.0

Comments

@Sukaato
Copy link
Member

Sukaato commented Aug 31, 2024

Prerequisites

Poppy UI Version

v1.x

Current Behavior

image

<PopButton type="submit" :form="form" outlined :disabled="isUploading || !canCreate">
  <span v-if="isUploading" slot="start" class="loading loading-spinner loading-sm"></span>
  <span>{{ $t('dashboard.studios.data.actions.create') }}</span>
</PopButton>

Expected Behavior

See the button

Steps to Reproduce

  1. Create a button with outlined & disabled set to true
  2. Button is not shown

Code Reproduction URL

No response

Additional Information

No response
@Sukaato Sukaato added the bug Something isn't working label Aug 31, 2024
@github-actions github-actions bot added the package: core @poppy-ui/core package related label Aug 31, 2024
@Sukaato Sukaato added this to the v1.0.0 milestone Aug 31, 2024
Sukaato added a commit that referenced this issue Sep 7, 2024
@Sukaato
fix(button): fix button css
0681847 
remove border-color transparent to fix button css
add basic test html file for manual test

fixes: #27
@Sukaato Sukaato mentioned this issue Sep 7, 2024
Merged
2 tasks
Sukaato added a commit that referenced this issue Sep 7, 2024
@Sukaato
fix(button): fix button css
fa5786c 
remove border-color transparent to fix button css
add basic test html file for manual test

fixes: #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sukaato Sukaato

Labels
bug Something isn't working package: core @poppy-ui/core package related
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix(button): fix button css CheeseGrinder/poppy-ui
1 participant
@Sukaato