Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug (core): disabled button does not have the correct color #35

Closed
3 tasks done
Sukaato opened this issue Sep 7, 2024 · 0 comments · Fixed by #43
Closed
3 tasks done

bug (core): disabled button does not have the correct color #35

Sukaato opened this issue Sep 7, 2024 · 0 comments · Fixed by #43
Assignees
Labels
bug Something isn't working package: core @poppy-ui/core package related
Milestone

Comments

@Sukaato
Copy link
Member

Sukaato commented Sep 7, 2024

Prerequisites

Poppy UI Version

v1.x

Current Behavior

Text and border does not have a visible color when disabled

:host([disabled])>button:disabled {
    --background: oklch(var(--neutral-oklch, 32.1785% 0.02476 255.701624) / 0.2);
    --color: oklch(var(--base-content-oklch, 27.8078% 0.029596 256.847952) / 0.2);
    pointer-events: none;
}

--color is not used

image

Expected Behavior

Have a visible disabled button

Steps to Reproduce

  1. Add button disabled / disabeld outlined
  2. Cant see the button on dark theme

Code Reproduction URL

No response

Additional Information

No response

@Sukaato Sukaato added the bug Something isn't working label Sep 7, 2024
@Sukaato Sukaato added this to the v1.0.0 milestone Sep 7, 2024
@github-actions github-actions bot added the package: core @poppy-ui/core package related label Sep 7, 2024
@Sukaato Sukaato changed the title bug (core): bug (core): disabled button does not have the correct color Sep 7, 2024
Sukaato added a commit that referenced this issue Sep 18, 2024
the --color was not used, force color with the property

fixes: #35
Sukaato added a commit that referenced this issue Sep 24, 2024
the --color was not used, force color with the property

fixes: #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core @poppy-ui/core package related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant