Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug (core): show-backdrop not aplied on pop-modal #52

Closed
3 tasks done
Sukaato opened this issue Sep 29, 2024 · 0 comments · Fixed by #54
Closed
3 tasks done

bug (core): show-backdrop not aplied on pop-modal #52

Sukaato opened this issue Sep 29, 2024 · 0 comments · Fixed by #54
Assignees
@Sukaato
Labels
bug Something isn't working package: core @poppy-ui/core package related
Milestone
v1.0.0

Comments

@Sukaato
Copy link
Member

Sukaato commented Sep 29, 2024

Prerequisites

Poppy UI Version

v1.x

Current Behavior

show-backdrop not aplied on pop-modal

Expected Behavior

have backdrop with color when show-backdrop is set to true

Steps to Reproduce

  1. Add a modal with show-backdrop set to true

Code Reproduction URL

No response

Additional Information

No response
@Sukaato Sukaato added the bug Something isn't working label Sep 29, 2024
@Sukaato Sukaato self-assigned this Sep 29, 2024
@Sukaato Sukaato added this to the v1.0.0 milestone Sep 29, 2024
@github-actions github-actions bot added the package: core @poppy-ui/core package related label Sep 29, 2024
Sukaato added a commit that referenced this issue Oct 1, 2024
@Sukaato
fix(modal): fix modal backdrop color
fa8cd45 
fixes: #52
@Sukaato Sukaato mentioned this issue Oct 1, 2024
Merged
2 tasks
@Sukaato Sukaato closed this as completed in 7ff6f28 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sukaato Sukaato

Labels
bug Something isn't working package: core @poppy-ui/core package related
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix(modal): fix modal backdrop color CheeseGrinder/poppy-ui
1 participant
@Sukaato