From 26217db138ff4642973e220fd01fc7cada1fe345 Mon Sep 17 00:00:00 2001 From: Amine Khaldi Date: Mon, 27 Jan 2025 21:40:25 +0100 Subject: [PATCH] fix new actionlint/shellcheck complaint (#19163) (#19174) * dump shellcheck and actionlint versions in ci * forward slashes Co-authored-by: Kyle Altendorf --- .github/workflows/build-windows-installer.yml | 8 ++++---- .github/workflows/upload-pypi-source.yml | 5 +++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-windows-installer.yml b/.github/workflows/build-windows-installer.yml index abf7de9cbe6f..0167edd24430 100644 --- a/.github/workflows/build-windows-installer.yml +++ b/.github/workflows/build-windows-installer.yml @@ -124,14 +124,14 @@ jobs: { echo "SM_HOST=${{ secrets.SM_HOST }}" echo "SM_API_KEY=${{ secrets.SM_API_KEY }}" - echo "SM_CLIENT_CERT_FILE=D:\\Certificate_pkcs12.p12" + echo "SM_CLIENT_CERT_FILE=D:/Certificate_pkcs12.p12" echo "SM_CLIENT_CERT_PASSWORD=${{ secrets.SM_CLIENT_CERT_PASSWORD }}" echo "SM_CODE_SIGNING_CERT_SHA1_HASH=${{ secrets.SM_CODE_SIGNING_CERT_SHA1_HASH }}" } >> "$GITHUB_ENV" { - echo "C:\Program Files (x86)\Windows Kits\10\App Certification Kit" - echo "C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools" - echo "C:\Program Files\DigiCert\DigiCert One Signing Manager Tools" + echo "C:/Program Files (x86)/Windows Kits/10/App Certification Kit" + echo "C:/Program Files (x86)/Microsoft SDKs/Windows/v10.0A/bin/NETFX 4.8 Tools" + echo "C:/Program Files/DigiCert/DigiCert One Signing Manager Tools" } >> "$GITHUB_PATH" - name: Setup SSM KSP on windows latest diff --git a/.github/workflows/upload-pypi-source.yml b/.github/workflows/upload-pypi-source.yml index 014bce1933ef..76314e035a3b 100644 --- a/.github/workflows/upload-pypi-source.yml +++ b/.github/workflows/upload-pypi-source.yml @@ -132,6 +132,11 @@ jobs: - name: actionlint command: | bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) + echo ==== shellcheck version + shellcheck --version + echo ==== actionlint version + ./actionlint --version + echo ==== running actionlint ./actionlint -color -shellcheck shellcheck steps: