PR feedback

Author: kroenlein

src/citrine/_serialization/properties.py

@@ -264,11 +264,17 @@ def underlying_types(self):
 
     @property
     def serialized_types(self):
-        return int, str
+        return float, int, str
 
     def _deserialize(self, value: SerializedInteger) -> int:
         if isinstance(value, bool):
             raise TypeError('value must be a Number, not a boolean.')
+        elif isinstance(value, float):
+            cast = round(value)
+            if cast == value:
+                return cast
+            else:
+                raise ValueError(f'{value} cannot be cast to an integer.')
         else:
             return int(value)
 

src/citrine/gemd_queries/filter.py

@@ -52,11 +52,14 @@ class AllIntegerFilter(Serializable['AllIntegerFilter'], PropertyFilterType):
         The lower bound on this filter range.
     upper: int
         The upper bound on this filter range.
+    inclusive: bool
+        Whether the lower & upper bounds are included in the range.
 
     """
 
     lower = properties.Integer('lower')
     upper = properties.Integer('upper')
+    inclusive = properties.Optional(properties.Boolean, 'inclusive', default=True)
     typ = properties.String('type', default="all_integer_filter", deserializable=False)
 
 

tests/_serialization/_data.py

@@ -5,6 +5,7 @@
 
 VALID_SERIALIZATIONS = [
     (properties.Integer, 5, 5),
+    (properties.Integer, 5, 5.),  # Accept passing a float-representation of an int to the setter
     (properties.Float, 3.0, 3.0),
     (properties.Raw, 1234, 1234),
     (properties.String, 'foo', 'foo'),