From 598c9fe305d25692a6e14ea806e3bc9badf8b9e9 Mon Sep 17 00:00:00 2001 From: Dakkshesh Date: Wed, 29 Jan 2025 23:50:08 +0530 Subject: [PATCH] tc_build/binutils: Move TemporaryDirectory() usage inside a with block To satisfy pylint. Fixes: tc_build/binutils.py:34:22: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) Signed-off-by: Dakkshesh --- tc_build/binutils.py | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/tc_build/binutils.py b/tc_build/binutils.py index a5262a40..c0de50a9 100644 --- a/tc_build/binutils.py +++ b/tc_build/binutils.py @@ -56,20 +56,23 @@ def build(self): self.folders.build.mkdir(exist_ok=True, parents=True) tc_build.utils.print_header(f"Building {self.target} binutils") - configure_cmd = [ - Path(self.folders.source, 'configure'), - *self.configure_flags, - ] + [f"{var}={val}" for var, val in self.configure_vars.items()] - self.run_cmd(configure_cmd, cwd=self.folders.build) - - make_cmd = ['make', '-C', self.folders.build, '-s', f"-j{os.cpu_count()}", 'V=0'] - self.run_cmd(make_cmd) - - if self.folders.install: - self.run_cmd([*make_cmd, 'install']) - tc_build.utils.create_gitignore(self.folders.install) - # Clean temporary dir containing docs after installing - self.tmpdir.cleanup() + # Redirect unwanted docs to a temporary dir + with TemporaryDirectory() as tmpdir: + doc_dirs = ['infodir', 'htmldir', 'pdfdir', 'mandir'] + self.configure_flags += [f"--{d}={tmpdir}" for d in doc_dirs] + + configure_cmd = [ + Path(self.folders.source, 'configure'), + *self.configure_flags, + ] + [f"{var}={val}" for var, val in self.configure_vars.items()] + self.run_cmd(configure_cmd, cwd=self.folders.build) + + make_cmd = ['make', '-C', self.folders.build, '-s', f"-j{os.cpu_count()}", 'V=0'] + self.run_cmd(make_cmd) + + if self.folders.install: + self.run_cmd([*make_cmd, 'install']) + tc_build.utils.create_gitignore(self.folders.install) class StandardBinutilsBuilder(BinutilsBuilder):