Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use less internals in DSS #2048

Closed
charleskawczynski opened this issue Oct 17, 2024 · 0 comments · Fixed by #2050
Closed

Use less internals in DSS #2048

charleskawczynski opened this issue Oct 17, 2024 · 0 comments · Fixed by #2050
Labels
refactor

Comments

@charleskawczynski
Copy link
Member

Our CUDA DSS implementation uses lots of DataLayout internals. Making any material changes to DataLayouts results in needing to nearly rewrite all of ext/cuda/topologies_dss.jl. I think that we need to refactor this code and avoid use of internals.

This is the biggest piece that blocks #2045.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define getindex_field and setindex_field CliMA/ClimaCore.jl
1 participant
@charleskawczynski