Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixField tests suddenly started breaking #2217

Closed
charleskawczynski opened this issue Mar 7, 2025 · 2 comments · Fixed by CliMA/UnrolledUtilities.jl#23
Closed

MatrixField tests suddenly started breaking #2217

charleskawczynski opened this issue Mar 7, 2025 · 2 comments · Fixed by CliMA/UnrolledUtilities.jl#23
Assignees
Labels
bug Something isn't working

Comments

@charleskawczynski
Copy link
Member

charleskawczynski commented Mar 7, 2025

Last working:

First fail (very next PR, which only touches tests, unrelated to MatrixFields):

@dennisYatunin, can you please take a look at this? (looks related to UnrolledUtilities)

@charleskawczynski charleskawczynski added the bug Something isn't working label Mar 7, 2025
@dennisYatunin
Copy link
Member

dennisYatunin commented Mar 7, 2025

Looks like the change to the tests made that particular MatrixFields test hit the recursion limit in unrolled_product, which calls Base's ntuple. I've rewritten unrolled_product without recursive calls to ntuple in the latest version of UnrolledUtilities, so upgrading the version should fix this.

@dennisYatunin
Copy link
Member

Oh wait, this is the latest version of UnrolledUtilities. I guess I since unrolled_product is called recursively it still hits the limit for ntuple. I will update UnrolledUtilities to avoid calling ntuple altogether. Also, this problem does not exist in 1.11 because the recursion limit is less stringent, but we can keep support for 1.10 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants