Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on join #17

Open
ZethiaZ opened this issue Dec 16, 2021 · 9 comments
Open

Crash on join #17

ZethiaZ opened this issue Dec 16, 2021 · 9 comments

Comments

@ZethiaZ
Copy link

ZethiaZ commented Dec 16, 2021

When I join the server the following error spams console and I am unable to connect from the server.

I am using debian and jdk 17. The plugins used are listed in the crash log (a /pl query was issued). The deluxehub version has been motified to accept unknown 1.8 server versions and has worked without issue on TacoSpigot and other 1.8 spigots I have used before.

crash.txt

@ghost
Copy link

ghost commented Dec 16, 2021

This seems to be caused by netty, a temporary fix is to disable "use-native-transport" in server.properties

@ZethiaZ
Copy link
Author

ZethiaZ commented Dec 16, 2021

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

@ghost
Copy link

ghost commented Dec 16, 2021

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

generate less garbage, and generally improve performance when compared to the NIO based transport.

@HeathLoganCampbell
Copy link
Member

HeathLoganCampbell commented Dec 17, 2021

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

generate less garbage, and generally improve performance when compared to the NIO based transport.

_wut, that's not true, if that was the case we would all disable it. What native transport does is use the java based networking, while Netty NIO uses special system level calls that can optimize packet sending. as well as bytebuf to use byte arrays on the heap instead off on the stack, which allows netty to produce less garbage, thus less GC time.

It breaks on java 17 because the current version of netty we use in BurritoSpigot doesn't support that java 17_
nvm rip, sorry, I was wrong, sorry about that

@ghost
Copy link

ghost commented Dec 17, 2021

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

generate less garbage, and generally improve performance when compared to the NIO based transport.

wut, that's not true, if that was the case we would all disable it. What it does is use the java based networking, while NIO uses special system level calls that can optimize packet sending. as well as bytebuf to use byte arrays on the heap instead off on the stack, which allows netty to produce less garbage, thus less GC time.

It breaks on java 17 because the current version of netty we use in BurritoSpigot doesn't support that java 17

Netty says that 😔 i got lied my whole life

@HeathLoganCampbell
Copy link
Member

Let me read more about this

@HowardZHY
Copy link
Contributor

Crashing could happen when someone joined. Plugins can see in these reports.

@HowardZHY
Copy link
Contributor

It seems like server crashes randomly when people join.
crash-2022-01-05_18.51.43-server.txt
crash-2022-01-05_19.01.55-server.txt
crash-2022-01-05_19.37.27-server.txt
crash-2022-01-05_22.03.45-server.txt
In fact, it crashes 6 times today :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants