Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting / Updating return data tests #1749

Open
OlivierBBB opened this issue Jan 29, 2025 · 0 comments
Open

Resetting / Updating return data tests #1749

OlivierBBB opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels

Comments

@OlivierBBB
Copy link
Collaborator

OlivierBBB commented Jan 29, 2025

We need to do tests of the following form

ROOT calls [CONTRACT 1] // this call should produce nonempty return data
ROOT resumes
ROOT executes [RETURNDATA sensitive opcode]

ROOT calls or creates [successful / reverted / aborts / FAILURE via exception / failed precompile / other halting] // this call should squash return data
ROOT resumes
ROOT executes [RETURNDATA sensitive opcode]

ROOT calls [CONTRACT 2] // this call should either [BALANCE_ABORT / produce different return data]
ROOT resumes
ROOT executes [RETURNDATA sensitive opcode]

ROOT stops

This test should be made parametric

  • the calls to CONTRACT 1 / CONTRACT 2 should be sourced from
    • simpleReturnDataProducer smc
    • precompile
    • nontrivial return data via REVERT
  • this call should have the option to abort (yes/no)
  • [RETURNDATA sensitive opcode]
    • from RETURNDATASIZE / RETURNDATACOPY
@OlivierBBB OlivierBBB self-assigned this Jan 29, 2025
@OlivierBBB OlivierBBB changed the title Squashing return data tests Resetting / Updating return data tests Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant