Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy usage improvements #93

Open
KonradUdoHannes opened this issue Jun 8, 2020 · 1 comment
Open

mypy usage improvements #93

KonradUdoHannes opened this issue Jun 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@KonradUdoHannes
Copy link
Collaborator

  • Datenguide Python version: 0.2.2

Description

In order to improve code quality and qa the mypy configuration could be improved, which includes. This would be particularly helpful with respect to external dependencies, such that imports don't default to the Any type.

Particular steps would be

  • check/improve the mypy configuration files
  • introduce mypy stub files, i.e. .pyi files containing stubs for depdncies. These could either be from a repository if available or these could be written explicitly (for the subset of required functions).
  • systematically check the code for the presence of type annotations (especially for the return values) and fill in missing annotations. This is particularly important if functions don't have any annotations at all, as these are ignored by mypy
@KonradUdoHannes KonradUdoHannes added the enhancement New feature or request label Jun 8, 2020
@KonradUdoHannes
Copy link
Collaborator Author

In order to perform the systematic checks for completeness of definitions it would probably be best to use the disallow_untyped_defs flag in mypy. This could be added to configuration in the repository in general once this issue is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant