Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate to python the R code from hackathon #11

Open
jralduaveuthey opened this issue Nov 23, 2022 · 2 comments
Open

translate to python the R code from hackathon #11

jralduaveuthey opened this issue Nov 23, 2022 · 2 comments
Assignees

Comments

@jralduaveuthey
Copy link
Collaborator

check the code from the transformation layer (from the hackathon) and start translate it to python in small functions

@jralduaveuthey
Copy link
Collaborator Author

@jannikrdev @LMSabi please make subtasks and distribute between Laura and you
Example: flagging, logging, ...
NOTE: there is already some python code from the hackathon. Code here https://github.com/correlaid/c7-etl-transform
Probably you should start defining the functions (inputs, outputs) to make them as generic (non cfe-specific) as possible.
The content of the functions can be cfe-specific

@jannikrdev
Copy link
Collaborator

jannikrdev commented Nov 28, 2022

Logging can be done with the built-in logging Python module which inherits its config from airflow.
I pushed an architecture proposal for the filtering part to a new branch feat/cleaning. Basically, we have two files: the cleaning.yaml part in which users can define which functions to call on what questions and the cleaning.py dag which will parse the yaml and call the functions accordingly. This way, we would have a quite generic solution while not compromising too much on UX.
Timo suggested using dynamic airflow DAG's, we'll implementing it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants